-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B 18428 int #12049
Merged
Merged
B 18428 int #12049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include features from main branch
MInthavongsay
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
r-mettler
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-18428
Summary
The Shipment Summary Worksheet is a file generated as part of the PPM Process. This task was to replace the existing png template images with a correctly filling PDF form template. This template can be viewed in Agility attachments for this story. This template was created in adobe, and then programmatically filled with a new service, SSWPPMGenerator. All new functions have unit tests written. A command and an API have both been updated to reflect the success of the generator, and will be elaborated on in testing instructions.
Is there anything you would like reviewers to give additional scrutiny?
this article explains more about the approach used.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
There are three tests that should be performed if possible, ranked from most to least important:
Access an SSW for an existing PPM Shipment. Requires a PPMShipment UUID.
The internal API Endpoint is: /ppm-shipments/{PPMShipmentID}/shipment_summary_worksheet?preparationDate=yyyy-mm-dd
So, an example would be:
http://milmovelocal:3000/internal/ppm-shipments/f093a13b-4ab8-4545-b24c-eb44bf52e605/shipment_summary_worksheet?preparationDate=2024-01-24
If you are logged in to MilMove as a User, and paste it into your URL with a correct PPMShipmentID from the database or your network tab under MTOShipments->ppmshipments->id, and a date, it should return the PDF to your browser.
This is also testable in SwaggerUI, but it will return PDF Code in the response viewer instead of to your browser, so please use the url bar.
Additionally, please be aware that many fields added in this version of the SSW are not yet available in the application. For a complete list of values and why they are unfilled, please review the Agility story.
Run the SSW Server test package, ensure all tests pass
These tests will test all new functions, as well as the form filling. It will fail if there is a corrupted or incorrectly configured PDF.
Frontend
officeApp
class or custommin-width
styling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots