Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 18428 int #12049

Merged
merged 35 commits into from
Feb 23, 2024
Merged

B 18428 int #12049

merged 35 commits into from
Feb 23, 2024

Conversation

antgmann
Copy link
Contributor

B-18428

Summary

The Shipment Summary Worksheet is a file generated as part of the PPM Process. This task was to replace the existing png template images with a correctly filling PDF form template. This template can be viewed in Agility attachments for this story. This template was created in adobe, and then programmatically filled with a new service, SSWPPMGenerator. All new functions have unit tests written. A command and an API have both been updated to reflect the success of the generator, and will be elaborated on in testing instructions.

Is there anything you would like reviewers to give additional scrutiny?

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

There are three tests that should be performed if possible, ranked from most to least important:

  1. Access an SSW for an existing PPM Shipment. Requires a PPMShipment UUID.
    The internal API Endpoint is: /ppm-shipments/{PPMShipmentID}/shipment_summary_worksheet?preparationDate=yyyy-mm-dd
    So, an example would be:
    http://milmovelocal:3000/internal/ppm-shipments/f093a13b-4ab8-4545-b24c-eb44bf52e605/shipment_summary_worksheet?preparationDate=2024-01-24
    If you are logged in to MilMove as a User, and paste it into your URL with a correct PPMShipmentID from the database or your network tab under MTOShipments->ppmshipments->id, and a date, it should return the PDF to your browser.
    This is also testable in SwaggerUI, but it will return PDF Code in the response viewer instead of to your browser, so please use the url bar.
    Additionally, please be aware that many fields added in this version of the SSW are not yet available in the application. For a complete list of values and why they are unfilled, please review the Agility story.

  2. Run the SSW Server test package, ensure all tests pass
    These tests will test all new functions, as well as the form filling. It will fail if there is a corrupted or incorrectly configured PDF.

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

@antgmann antgmann added Scrummy Bears Scrum Team H INTEGRATION Slated for Integration Testing labels Feb 23, 2024
@antgmann antgmann self-assigned this Feb 23, 2024
@antgmann antgmann requested a review from a team as a code owner February 23, 2024 13:28
Copy link
Contributor

@MInthavongsay MInthavongsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@r-mettler
Copy link
Contributor

image Looks good. Only thing I noticed which is not a huge deal is if data isn't present for most of the fields we leave them blank. But for the SIT dates it has text put in saying there weren't any dates. Some of these are long and are cut off, was this a requirement to populate with text? If not then I think just leaving them blank would suffice. Again this could be something addressed later on.

@r-mettler r-mettler merged commit 74a3f53 into integrationTesting Feb 23, 2024
30 checks passed
@r-mettler r-mettler deleted the B-18428-INT branch February 23, 2024 21:12
@antgmann antgmann mentioned this pull request Feb 26, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Scrummy Bears Scrum Team H
Development

Successfully merging this pull request may close these issues.

4 participants